mommy wants to be more ominous~ #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
approved these changes
Jul 26, 2024
jyn514
left a comment
jyn514
left a comment
There was a problem hiding this comment.
this gave me the fabulous idea to upper-case pronoun in all the ominous moods, i might make a pr for that later
| "{role} has seen worse. {pronoun} devoted {affectionate_term} can fix it. ...probably", | ||
| "{role} expected better from you. do not disappoint {pronoun} again", | ||
| "It seems {role}'s {affectionate_term} is becoming careless", | ||
| "{affectionate_term}, you are tarnishing the reputation of this house" |
There was a problem hiding this comment.
this looks like the first response that begins with affectionate_term. my understanding is that it's usually lowercase ("girl") by default. should we uppercase the first letter for consistency?
we may also want to consider ending all these phrases with a period if they don't have other punctuation, but that's a larger change, you don't have to do it here.
Owner
There was a problem hiding this comment.
in #83 we actually moved to everything being lower haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.