Add a few points to intTests/README that aren't written down anywhere #2274
Conversation
| For tests that need binary artefacts (Java bytecode, LLVM bitcode) or | ||
| things that might as well be (linked-mir.json from mir-json) include | ||
| the corresponding source and a (gmake) Makefile that builds the |
There was a problem hiding this comment.
| For tests that need binary artefacts (Java bytecode, LLVM bitcode) or | |
| things that might as well be (linked-mir.json from mir-json) include | |
| the corresponding source and a (gmake) Makefile that builds the | |
| For tests that need binary artefacts (Java bytecode, LLVM bitcode) or | |
| things that might as well be (linked-mir.json from mir-json), include | |
| the corresponding source and a (gmake) Makefile that builds the |
| For tests that need binary artefacts (Java bytecode, LLVM bitcode) or | ||
| things that might as well be (linked-mir.json from mir-json) include | ||
| the corresponding source and a (gmake) Makefile that builds the | ||
| artefact, as well as the artefact itself. |
There was a problem hiding this comment.
A minor thing, but this README is a bit inconsistent about whether it uses the spelling "artifact" vs. "artefact". I have a mild preference towards the former since it uses the American English spelling, but I don't feel strongly. Either way, we should use one or the other consistently.
There was a problem hiding this comment.
Since working on data provenance years ago I use "artefact" for physical objects and "artifact" for constructs (as in, your data may have artifacts, your data is an artefact) because in that context it can be quite confusing to not be careful about that distinction. Here it doesn't really matter, but since most of the uses are ones I just added I updated the other to match.
intTests/README.md
Outdated
| things that might as well be (linked-mir.json from mir-json) include | ||
| the corresponding source and a (gmake) Makefile that builds the | ||
| artefact, as well as the artefact itself. | ||
| Indicate other provenance information in the makefile (e.g. LLVM version and |
There was a problem hiding this comment.
| Indicate other provenance information in the makefile (e.g. LLVM version and | |
| Indicate other provenance information in the Makefile (e.g. LLVM version and |
(or at least not anywhere accessible, e.g. I think the #! discussion was in an issue somewhere)
sauclovian-g
force-pushed
the
improve-intTest-readme
branch
from
c1f9027 to
91a4d5b
Compare
Prompted by some stuff that came up in #2272.