Add TOTP copy button to messages that look like they have a TOTP code and fix undefined in notification#2111
Open
xethlyx wants to merge 2 commits intoGSConnect:mainfrom
Open
Add TOTP copy button to messages that look like they have a TOTP code and fix undefined in notification#2111xethlyx wants to merge 2 commits intoGSConnect:mainfrom
xethlyx wants to merge 2 commits intoGSConnect:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pictures are worth a thousand words, so here's a before and after:
Closes #1588
Closes #1108
Since phone numbers can look a lot like TOTP codes, to minimize the amount of false positives, I only opted to include codes that matched 6 digits with whitespace before/after.
If necessary, I can split this into two pull requests. Happy holidays!
EDIT: After daily driving these patches, I noticed some TOTP providers may add a period at the end of the code, e.g.
Your code is 123456.. I've amended the logic to also allow periods.