Fix sensitivity state for "Share When Active" button#2095
Open
Vict0rTesla wants to merge 2 commits intoGSConnect:mainfrom
Open
Fix sensitivity state for "Share When Active" button#2095Vict0rTesla wants to merge 2 commits intoGSConnect:mainfrom
Vict0rTesla wants to merge 2 commits intoGSConnect:mainfrom
Conversation
Author
Member
|
Not until next week at the earliest, I'm afraid. |
Author
|
@ferdnyc Hi, just following up on the PR review when you get a moment. No rush — just making sure it’s still on your radar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the sensitivity state of the
Share When Activebutton.Previously. the button's sensitivity was controlled using the UI bind method.
which caused the initial state to be incorrect when opening the window.
I updated the implementation to use the same sensitivity handling pattern as
notifications-apps, ensuring the correct state is applied consistently.Fixes #1599