Set appropriate window application and titles instead of defaulting to gsconnect#1875
Set appropriate window application and titles instead of defaulting to gsconnect#1875sidevesh wants to merge 3 commits intoGSConnect:mainfrom
Conversation
sidevesh
changed the title
sidevesh
changed the title
ferdnyc
left a comment
ferdnyc
left a comment
There was a problem hiding this comment.
I'm not at all sold on most of these. They appear to be solutions in search of a problem, and many are redundant with the UI template definitions. (Redundancy is bad.) -1 from me without better justification for why it's necessary.
src/service/ui/legacyMessaging.js
Outdated
| _init(params) { | ||
| super._init({ | ||
| application: Gio.Application.get_default(), | ||
| title: _('Send SMS'), |
There was a problem hiding this comment.
This is already set in the template, setting it here is redundant and makes maintenance harder:
src/service/ui/messaging.js
Outdated
| super._init(params); | ||
| super._init(Object.assign({ | ||
| application: Gio.Application.get_default(), | ||
| title: _('Messaging'), |
There was a problem hiding this comment.
This is already set in the template, setting it here is redundant and makes maintenance harder:
src/service/ui/mousepad.js
Outdated
| _init(params) { | ||
| super._init(Object.assign({ | ||
| application: Gio.Application.get_default(), | ||
| title: _('Remote Input'), |
There was a problem hiding this comment.
This is set by defining the headerbar.title, which is the title of a GtkDialog in every way that matters.
In the application dash and overview:
In the Gtk Inspector:
What issue are you trying to solve, by also passing a title parameter to the constructor?
src/service/ui/notification.js
Outdated
| _init(params) { | ||
| super._init({ | ||
| application: Gio.Application.get_default(), | ||
| title: _('Reply'), |
There was a problem hiding this comment.
In this case, headerbar.title is set to params.notification.appName, which will be the title of the dialog in every way that matters. What's the purpose of also setting it generically, here?
src/service/ui/service.js
Outdated
| super._init({ | ||
| use_header_bar: true, | ||
| application: Gio.Application.get_default(), | ||
| title: params.title, |
There was a problem hiding this comment.
title is already set in the template, as Select a Device, which is why params.title is set as the headerbar subtitle:
src/service/plugins/findmyphone.js
Outdated
| _init(params) { | ||
| super._init({ | ||
| application: Gio.Application.get_default(), | ||
| title: _('Ringing'), |
There was a problem hiding this comment.
This dialog is a mess, and doesn't appear to have a title at all. So I'll probably give you this one. But really it should probably be redone with a UI template definition, like basically every other window in the code.
(Actually now that notifications can have persistent action buttons (FINALLY!), it might make way more sense to replace the entire dialog with an urgent notification that has a "Silence" or "Acknowledge" action button embedded.)
|
The tests are failing in the CI because you added |
|
Sorry for the messy changes, I was trying to solve the issue of generic gsconnect icon and name in the dash, |
2 participants
No description provided.