Cypress upgrade #803
Merged
Cypress upgrade #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btylerburton
approved these changes
Jan 30, 2025
|
|
||
| afterEach(() => { | ||
| after(() => { | ||
| cy.logout(); |
There was a problem hiding this comment.
do you want logout afterEach?
There was a problem hiding this comment.
We should, but since we have cy.login() in beforeEach, and it does a cy.logout() implicitly, so no need to add the extra code.
If we ever remove cy.login() from beforeEach, i would come back and add cy.logout() into afterEach.
There was a problem hiding this comment.
it does a cy.logout() implicitly
aha. yeah that makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get cypress upgraded to recent version and fix tests, preparing for GSA/data.gov#4861
crypress runcommand so that it is more robust when run PR checksgoogleanalyticsbasicthat is not being used