Improve foundry setup #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.7.6
This was referenced Feb 29, 2024
…pting all other changes.
Owner
|
Apologies for the delay and thank you for the contributions! 🙏 |
GNSPS
added a commit
that referenced
this pull request
Feb 6, 2025
* Add funding JSON file for RetroPGF * Improve foundry setup (#67) * chore: Remove dependencies * chore: Add foundry.toml * forge install: forge-std v1.7.6 * chore: Remove remappings * chore: Add .nvmrc * chore: Add test workflow * chore: Setup foundry in github workflow * fix: Include recursive submodules in github workflow * Deleting GitHub workflow from the PR because of safety concerns. Accepting all other changes. --------- Co-authored-by: Gonçalo Sá <[email protected]> * Remove non-aligned equality function to address concerns in #69 --------- Co-authored-by: Ján Jakub Naništa <[email protected]>
Contributor
Author
|
You're most welcome @GNSPS ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
dependenciesfrompackage.jsonforge-stddependency is quite outdated, preferred way of installing this isforge install foundry-rs/forge-stdnode_modules(as opposed todevDependencies)foundry.tomland removeremappings.txt@niran let me know if there are any changes you'd like to me to make, more than happy to oblige!