Remove node-sass to help avoid some install issues #1607
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
this one actually does not look right, may have to be closed
|
Contributor
Author
|
Note added to README describing that users may need to use node 14 or less to install jbrowse from github, and might also apply to users using plugins or dev versions of jbrowse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to GMOD/jbrowse-components#2062
This uses sass-loader@^10 which depends on sass instead of node-sass, which is a pure-js implementation of sass and doesn't spin up c compilers, etc.
The version sass-loader@^10 is similar to what is used by current react-scripts@^4