-
Notifications
You must be signed in to change notification settings - Fork 40
Filter dialog button text and icon #2537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter dialog button text and icon #2537
Conversation
|
Is there anything you would suggest instead @RobAndrewHurst? |
|
@jfitzpatrick17 "Choose Filters" Or "Filters" or "Filter" might work better? |
|
Thanks @RobAndrewHurst. I think "Filters" is my favourite of the 3. |
|
dbauszus-glx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the english dictionary to say "Filters" instead of "Apply Filters" which doesn't make sense.
I removed the Korean and Turkish entries. I suggest these were done with Google Translate. There is no need to use Google translate to update and add individual dictionary entries.
Google translate can be used to translate the interface as a whole. The dictionary entries should be reserved for content from native speakers of a language.




Minor change for multi filter button.
Changed wording to get rid of the word
panelAdded filter_alt icon.
Button css now has a
color:inheritrule on button inner elements to align symbol icon with font if a symbol icon is used.