Skip to content

Conversation

@cityremade
Copy link
Member

Minor change for multi filter button.
Changed wording to get rid of the word panel
Added filter_alt icon.
Button css now has a color:inherit rule on button inner elements to align symbol icon with font if a symbol icon is used.

@cityremade cityremade linked an issue Dec 8, 2025 that may be closed by this pull request
@cityremade cityremade self-assigned this Dec 8, 2025
@cityremade cityremade added CSS Changes in stylesheets UI labels Dec 8, 2025
@cityremade cityremade marked this pull request as ready for review December 8, 2025 11:13
@RobAndrewHurst
Copy link
Contributor

image

I don't think "Apply Filters" is the correct wording for this because it feels like an instant action. Not to bring up a dialog to then apply the filters

@jfitzpatrick17
Copy link

Is there anything you would suggest instead @RobAndrewHurst?

@RobAndrewHurst
Copy link
Contributor

@jfitzpatrick17 "Choose Filters" Or "Filters" or "Filter" might work better?

@jfitzpatrick17
Copy link

Thanks @RobAndrewHurst. I think "Filters" is my favourite of the 3.

@dbauszus-glx dbauszus-glx changed the title Styling for filter button. Styling for filter button Dec 9, 2025
@dbauszus-glx dbauszus-glx self-requested a review December 9, 2025 11:53
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the english dictionary to say "Filters" instead of "Apply Filters" which doesn't make sense.

I removed the Korean and Turkish entries. I suggest these were done with Google Translate. There is no need to use Google translate to update and add individual dictionary entries.

Google translate can be used to translate the interface as a whole. The dictionary entries should be reserved for content from native speakers of a language.

image

@dbauszus-glx dbauszus-glx changed the title Styling for filter button Filter dialog button text and icon Dec 9, 2025
@RobAndrewHurst RobAndrewHurst merged commit 450173c into GEOLYTIX:minor Dec 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CSS Changes in stylesheets UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Addition of icon to filter panel button

5 participants