Replace bcrypt node module with utils module #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
dbauszus-glx
requested review from
AlexanderGeere,
RobAndrewHurst,
cityremade and
simon-leech
Member
Author
|
To test this it must be ensure that it is possible to validate existing password, register and hash new password, allow for password resets. |
dbauszus-glx
added
Code
Member
Author
|
I have updated the requires and include the bcrypt functions which are used in the module docs.
|
RobAndrewHurst
approved these changes
Nov 1, 2024
|
simon-leech
approved these changes
Nov 4, 2024
Contributor
simon-leech
left a comment
simon-leech
left a comment
There was a problem hiding this comment.
All working for me with resetting password, registering a new user too
RobAndrewHurst
added a commit
that referenced
this pull request
Nov 6, 2024
Replace bcrypt node module with utils module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied the bcrypt script from this build distro module. https://github.com/dcodeIO/bcrypt.js/blob/master/dist/bcrypt.js