Skip to content

Conversation

@daften
Copy link
Contributor

@daften daften commented Jun 19, 2025

This fixes the additional item I mentioned in #629 (comment)

I updated and added automatic tests that should capture the changed behaviour too. I placed the error in the episode method, that seemed the best place to me, but I can easily move it to e.g. the get_media_metadata method.

@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (36c55e1) to head (fcec81f).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #642      +/-   ##
==========================================
+ Coverage   84.29%   84.31%   +0.02%     
==========================================
  Files          66       66              
  Lines        6092     6096       +4     
==========================================
+ Hits         5135     5140       +5     
+ Misses        957      956       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FuzzyGrim
Copy link
Owner

Thank you for addressing that issue!

The providers/manual.py is for manually created entries (https://yamtrack.fuzzygrim.com/create), the file you should change is providers/tmdb.py. Also instead of creating services.MediaNotFoundError I would prefer to trigger services.ProviderAPIError as it's already handling other cases of media not found.

@daften daften force-pushed the feature/episode-not-found branch from 88516a3 to 7e02276 Compare June 24, 2025 20:26
@daften
Copy link
Contributor Author

daften commented Jun 24, 2025

I've rebased my changes on top of dev and I've made the changes as requested, not using a new Error, but the existing Error and putting it in tmdb.py! Let me know how this looks to you! :)

@FuzzyGrim FuzzyGrim merged commit 3d5bd3c into FuzzyGrim:dev Jun 28, 2025
8 checks passed
@FuzzyGrim
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants