Skip to content

Conversation

@ryck
Copy link
Contributor

@ryck ryck commented Jun 4, 2025

At this point you may want to do some refactoring so we can share some functions between webhooks (maybe the ones related to yamtrack models, like to add an item to yamtrack)

Another option would be to use the same file, but get the parameter from the URL (ie, jellyfin|plex|emby) and work with that, but I don't particulary like that option, I like to have one file for each integration...

So maybe having some common functions is the best approach?

Also, do you think there is interest for a Tautulli integration, so you don't need a Plex Pass to use webhooks?

@FuzzyGrim
Copy link
Owner

Yes, I'll refactor it after the merge. Could you add some tests with sample payloads so I can work with it?

Thanks.

@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 75.53957% with 34 lines in your changes missing coverage. Please review.

Project coverage is 83.95%. Comparing base (7637919) to head (170d73d).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/integrations/webhooks/emby.py 73.17% 33 Missing ⚠️
src/integrations/views.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #578      +/-   ##
==========================================
- Coverage   84.18%   83.95%   -0.24%     
==========================================
  Files          64       65       +1     
  Lines        5944     6089     +145     
==========================================
+ Hits         5004     5112     +108     
- Misses        940      977      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FuzzyGrim FuzzyGrim merged commit 3ae9ac8 into FuzzyGrim:dev Jun 10, 2025
6 of 7 checks passed
@FuzzyGrim
Copy link
Owner

I have done some refactoring in dev, all the tests are passing but if possible, could you verify that both Plex and Emby webhooks are working as expected?

Also, do you think there is interest for a Tautulli integration, so you don't need a Plex Pass to use webhooks?

Yes, can it copy exactly the Plex Webhook payload format? If so, we could use the same end point, right?

I'm thinking of releasing v0.24.0 soon, do you think we could add the Plex webhook handler for the rate event?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants