Improve raw_ptr::write (1/n)

[xunilrj]

Description

This PR is the first of a series trying to make raw_ptr::write optimal. For now, we tackle the issue that it was not being inlined.

The issue is that we only check for inlining at certain points, and some optimisations were being run after this check, ignoring the inlining even when it made sense.

The solution is to run the optimisation pipeline multiple times, a standard practice. For that, I had to fix other passes that were returning true for modified even when they do not change anything. This allows us to break the loop as early as possible.

Compilation time impact remains to be checked, but we can remove the loop on debug builds if that presents itself as a problem.

Checklist

• I have linked to any relevant issues.
• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • If my change requires substantial documentation changes, I have requested support from the DevRel team
• I have added tests that prove my fix is effective or that my feature works.
• I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
• I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
• I have requested a review from the relevant team or maintainers.

[xunilrj]

e2e-gas-usage

	Improvements	Regressions
Count	1038	51
Average	2.48%	-0.92%
Median	0.52%	-0.28%
Max	94.39%	-5.59%
Min	0.10%	-0.01%

e2e-bytecode-size

	Improvements	Regressions
Count	130	25
Average	11.80%	-4.73%
Median	5.44%	-3.17%
Max	97.61%	-18.34%
Min	0.13%	-0.16%

o2-bytecode-size

	Improvements	Regressions
Count	3	2
Average	2.94%	-0.59%
Median	3.30%	-0.59%
Max	3.55%	-0.92%
Min	1.97%	-0.26%

o2-gas-usage

	Improvements	Regressions
Count	1	1
Average	25.16%	-0.42%
Median	25.16%	-0.42%
Max	25.16%	-0.42%
Min	25.16%	-0.42%

Test	Before	After	Percentage
contract_libs::test_u56	480	482	-0.42%
src20-token::storage_sizes_of_stored_types	640	479	25.16%

[codspeed-hq]

Merging this PR will degrade performance by 20.32%

❌ 1 regressed benchmark
✅ 24 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
❌	tokens_for_program	520.2 µs	652.8 µs	-20.32%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing xunilrj/improve-rawptr-write (7196d95) with master (52671eb)}

[ironcev]

👍