forc-doc: Preserve all doc links when merging parallel results #7379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries, ensuring deduplication of links.
JoshuaBatty
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
JoshuaBatty
added
bug
…td/ and rewrote HTML paths
JoshuaBatty
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
CodSpeed Performance ReportMerging #7379 will not alter performanceComparing Summary
|
kayagokalp
approved these changes
Sep 11, 2025
JoshuaBatty
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
IGI-111
approved these changes
Sep 11, 2025
Elaela22soL
pushed a commit
to Elaela22soL/sway
that referenced
this pull request
Sep 26, 2025
…abs#7379) ## Description The sway-lib-std docs are broken and not showing all of the generated documentaiton. The root `index.html` was showing only one module while `all.html` listed only a subset of types. This started happening after the parallel processing was introduced in FuelLabs#7296. This PR fixes this as can be seen in the screenshots below. Also undoes the CI changes in FuelLabs#7362 & FuelLabs#7365 as they aren't necessary as this was the root cause. - Root cause: Using BTreeMap::extend to merge per-item results overwrote existing per-category vectors, so only the last chunk from parallel processing survived. - Fix: replace `.extend` merges with per-key append-and-dedup loops. Before: <img width="1608" height="1040" alt="before" src="https://github.com/user-attachments/assets/e433fcc2-cce6-4737-8ed3-c9e2a679de5a" /> After: <img width="1608" height="1040" alt="after" src="https://github.com/user-attachments/assets/c9e9c007-df6a-49b3-b864-e30d19f487f2" /> ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sway-lib-std docs are broken and not showing all of the generated documentaiton. The root
index.htmlwas showing only one module whileall.htmllisted only a subset of types. This started happening after the parallel processing was introduced in #7296. This PR fixes this as can be seen in the screenshots below.Also undoes the CI changes in #7362 & #7365 as they aren't necessary as this was the root cause.
.extendmerges with per-key append-and-dedup loops.Before:
After:
Checklist
Breaking*orNew Featurelabels where relevant.