-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat!: non-blocking blob deployment #2929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/feat/blob-contract-deploys
…/feat/blob-contract-deploys
…/feat/blob-contract-deploys
…/feat/blob-contract-deploys
Co-authored-by: Peter Smith <[email protected]>
…/feat/blob-contract-deploys
arboleya
reviewed
Aug 14, 2024
Torres-ssf
reviewed
Aug 14, 2024
Torres-ssf
previously approved these changes
Aug 14, 2024
Contributor
Torres-ssf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🚀
petertonysmith94
previously approved these changes
Aug 14, 2024
nedsalk
reviewed
Aug 14, 2024
980ec66
Contributor
|
Coverage Report:
Changed Files:
|
Torres-ssf
approved these changes
Aug 14, 2024
petertonysmith94
approved these changes
Aug 14, 2024
nedsalk
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
ContractFactory.deployAsBlobTxa non-blocking callSummary
In #2827
ContractFactory.deployAsBlobTxwas introduced as a blocking call. This is because we need to await the blob transactions before submitting a non-blocking create transaction.This PR makes the blob txs non blocking, however we now need to make the transaction ID returned from contract deployment into a promise. This is because we do not have access to the transaction ID until we have funded the create call, due to potentially changing UTXOs.
Breaking Changes
The transaction ID from a contract deployment is now returned as a promise.
Checklist