Skip to content

Conversation

@petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Jan 22, 2025

Related to: FuelLabs/fuels-ts#3482

Summary

Passing the module_or_path directly is deprecated, it now expects an object with the module_or_path key (reference).

Reproduction

  • Using node@22 on master, build and test and you'll encounter the following warning:

    using deprecated parameters for the initialization function; pass a single object instead

  • Using node@22 on ps/fix/deprecation-warning, build and test, the error should not be present.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

@petertonysmith94 petertonysmith94 added the bug Something isn't working label Jan 22, 2025
@petertonysmith94 petertonysmith94 self-assigned this Jan 22, 2025
@petertonysmith94 petertonysmith94 added this pull request to the merge queue Jan 24, 2025
Merged via the queue into master with commit 418360a Jan 24, 2025
40 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/fix/deprecation-warning branch January 24, 2025 09:31
@Dentosal Dentosal mentioned this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants