-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(storage): custom impl of EnumCount for MerkleizedColumn #2875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
2920565
50ad256
284d9ad
f7de919
70b46eb
5231d6e
9f62a7a
aa438a2
4ccf140
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,6 @@ use alloc::{ | |
| Eq, | ||
| Hash, | ||
| enum_iterator::Sequence, | ||
| strum_macros::EnumCount, | ||
| strum_macros::IntoStaticStr, | ||
| )] | ||
| pub enum MerkleizedColumn<TC> { | ||
|
|
@@ -31,6 +30,16 @@ pub enum MerkleizedColumn<TC> { | |
| MerkleMetadataColumn, | ||
| } | ||
|
|
||
| impl<TC> strum::EnumCount for MerkleizedColumn<TC> | ||
| where | ||
| TC: strum::EnumCount + AsU32, | ||
| { | ||
| /// The total count of variants in the enum. | ||
| /// Since we have two columns for each table column and one for the merkle data, | ||
| /// we have to multiply the count of the table columns by 2 and add one for the merkle metadata. | ||
| const COUNT: usize = TC::COUNT * 2 + 1; | ||
| } | ||
|
|
||
| /// The trait to convert the column to the `u32`. | ||
| pub trait AsU32 { | ||
| /// Returns the `u32` representation of the `Column`. | ||
|
|
@@ -42,9 +51,7 @@ where | |
| TC: strum::EnumCount + AsU32, | ||
| { | ||
| /// The total count of variants in the enum. | ||
| /// Since we have two columns for each table column and one for the merkle data, | ||
| /// we have to multiply the count of the table columns by 2 and add one for the merkle metadata. | ||
| pub const COUNT: usize = TC::COUNT * 2 + 1; | ||
| pub const COUNT: usize = <Self as strum::EnumCount>::COUNT; | ||
|
|
||
| /// The start of the merkle data columns. | ||
| pub const MERKLE_DATA_COLUMNS_START: u32 = u16::MAX as u32; | ||
|
|
@@ -56,7 +63,9 @@ where | |
| Self::MerkleDataColumn(column) => { | ||
| Self::MERKLE_DATA_COLUMNS_START.wrapping_add(column.as_u32()) | ||
| } | ||
|
||
| Self::MerkleMetadataColumn => u32::MAX, | ||
| Self::MerkleMetadataColumn => { | ||
| Self::COUNT.checked_sub(1).unwrap().try_into().unwrap() | ||
| } | ||
netrome marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
| } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.