Skip to content

Fix RocksDB closing #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Fix RocksDB closing #2730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e46bcc9
Fix RocksDB closing
xgreenx Feb 19, 2025
5513947
Update CHANGElog
xgreenx Feb 19, 2025
47cc498
Merge branch 'master' into bugfix/fix-erroring-db-close
AurelienFT Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changes/fixed/2730.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed RocksDB closing issue that potentially could panic.
1 change: 1 addition & 0 deletions crates/fuel-core/src/state/rocks_db.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ impl<Description> Drop for RocksDb<Description> {
// Drop the snapshot before the db.
// Dropping the snapshot after the db will cause a sigsegv.
self.snapshot = None;
self.db.cancel_all_background_work(true);
}
}

Expand Down
Loading