OrderByPipe .toLowerCase function only exists on strings

[gtsopour]

For some reason and on specific cases only, I was receiving that t.toLowerCase() is not functioning. I managed to overpass this issue by editing the following:

if((isNaN(parseFloat(a)) || !isFinite(a)) || (isNaN(parseFloat(b)) || !isFinite(b))){
//Isn't a number so lowercase the string to properly compare
if(a.toString().toLowerCase() < b.toString().toLowerCase()) return -1;
if(a.toString().toLowerCase() > b.toString().toLowerCase()) return 1;
}
else{
//Parse strings as numbers to compare properly
if(parseFloat(a) < parseFloat(b)) return -1;
if(parseFloat(a) > parseFloat(b)) return 1;
}

Could you please check that?

Best
George

[coryshaw1]

It seems that a string is not being passed, and you are trying to sort on an object. Can you give an example of the object being passed?

You can use {{arrayBeingPassedToOrderBy | json}} in your template to see exactly what you're giving to the OrderBy pipe

[stevemeyers]

Hi Cory,

It looks like booleans slip into the "isn't a number" if statement posted in this thread. parseFloat(true) returns NaN, so booleans fall in. That may be what George was seeing.

Best,
Steve

[mtycholaz]

This is also a problem with Date objects

[giorgiofellipe]

this is also a problem with boolean properties

[coryshaw1]

Date and booleans have both been fixed in a newer branch. Feel free to use the updated code here: https://github.com/FuelInteractive/fuel-ui/blob/feature/update_from_internal/src/pipes/OrderBy/OrderBy.ts