ci : change licensing on nix

[FreeYourSoul]

Summary by CodeRabbit

• Chores
  • Enhanced build and installation support with improved CMake configuration and package setup.
  • Updated dependency revisions and checks for build consistency.
  • Removed several test suites and disabled specific test files to streamline testing.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The update enhances the build and packaging system by adding CMake installation support, configuration files, and flags for proper prefix paths. It modifies Nix expressions to override dependencies with CMake install flags and sanitizes config files post-install. Several test files and targets are removed or disabled. The fabko license attribute is removed. A new .nix/result file referencing the build output is added.

Changes

File(s)	Change Summary
.nix/fabko.nix	Added cmakeFlags and preConfigure attributes; removed license attribute from meta section.
.nix/import-from-json.nix	Stored imported dependency in variable; if derivation, overridden to append CMake install flags, enable install check, and add postInstall script sanitizing config files; error thrown otherwise.
.nix/nix-dep.json	Updated revision commit hash and SHA-256 checksum for fil dependency.
.nix/result	Added new file referencing Nix store path for fabko build output.
CMakeLists.txt	Added GNUInstallDirs, conditional test subdirectory addition, installation rules for fabko binaries and config files; prints resolved install directories.
cmake/fabkoConfig.cmake.in	Added new CMake package config file initializing package, including targets, and checking required components.
tests/CMakeLists.txt	Removed entire test_datastore executable target and related configuration.
tests/agent/test_acl.cpp	Entire source file commented out line-by-line, disabling compilation and execution.
tests/peerboard/test_kv_rocksdb.cpp	Entire file deleted, removing RocksDB key-value store unit tests.
fabko/CMakeLists.txt	Changed target_include_directories for fabko from PUBLIC to PRIVATE; fixed typo in target_link_libraries; corrected target_compile_features target from agent to fabko.
fabko/common/exception.hh	Removed logging call from fabko_assert in release mode (NDEBUG), making it a no-op without side effects.

Poem

🐇 In build files deep, a change did creep,
Licenses gone and flags to keep.
CMake paths set with care and grace,
Tests now silent, a quiet place.
From nix to cmake, the rabbit hops,
With clean installs and no license stops!
🌿✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd2d508 and 3f8374a.

📒 Files selected for processing (11)

• .nix/fabko.nix (1 hunks)
• .nix/import-from-json.nix (1 hunks)
• .nix/nix-dep.json (1 hunks)
• .nix/result (1 hunks)
• CMakeLists.txt (2 hunks)
• cmake/fabkoConfig.cmake.in (1 hunks)
• fabko/CMakeLists.txt (1 hunks)
• fabko/common/exception.hh (0 hunks)
• tests/CMakeLists.txt (0 hunks)
• tests/agent/test_acl.cpp (1 hunks)
• tests/peerboard/test_kv_rocksdb.cpp (0 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99b7f47 and eb9f404.

📒 Files selected for processing (1)

• .nix/fabko.nix (1 hunks)

🧰 Additional context used

🪛 GitHub Actions: CI Linux Build

.nix/fabko.nix

[error] 69-69: Nix build failed due to undefined variable 'unfree' used in license attribute.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Codacy Static Code Analysis