Handle lockup views with no published text or views #8170
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: absidue <[email protected]>
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
absidue and
kommunarr
github-actions
bot
added
the
PR: waiting for review
absidue
approved these changes
Oct 21, 2025
|
I bisected the issue from the original thread and got close to creating the same pull request after noticing those recommendations. 😄 This does resolve the issue for me. |
PikachuEXE
approved these changes
Oct 22, 2025
ChunkyProgrammer
approved these changes
Oct 27, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 30, 2025
* development: Translated using Weblate (Russian) Bump the eslint group with 2 updates (FreeTubeApp#8184) Bump the babel group with 2 updates (FreeTubeApp#8185) Bump sass-loader from 16.0.5 to 16.0.6 (FreeTubeApp#8186) Bump electron from 38.3.0 to 38.4.0 (FreeTubeApp#8187) Bump swiper from 12.0.2 to 12.0.3 (FreeTubeApp#8189) Bump actions/upload-artifact from 4 to 5 (FreeTubeApp#8188) Bump lefthook from 2.0.0 to 2.0.1 (FreeTubeApp#8190) Handle lockup views with no published text or views (FreeTubeApp#8170) Translated using Weblate (Russian) Translated using Weblate (Russian) Remove Hide Channel from the kebab menu on the Subscriptions page (FreeTubeApp#8175) Translated using Weblate (French) Translated using Weblate (Latvian) Translated using Weblate (Latvian) Translated using Weblate (Portuguese (Portugal)) Bump lefthook from 1.13.6 to 2.0.0 (FreeTubeApp#8166)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Closes #8155
Description
Users were unable to watch videos if the recommended section had videos in them that had no published text or views
Screenshots
Before watch page blanks out:
After users are able to view videos and videos in the recommended section:
How it looks on YT:
Testing
Desktop
Additional context
I could only reproduce these errors after i vpned to usa otherwise videos played normally