Remove unneeded electron-builder-squirrel-windows dependency #2560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
added
the
PR: waiting for review
absidue
requested review from
ChunkyProgrammer,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
PikachuEXE
approved these changes
Sep 10, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 10, 2022
ChunkyProgrammer
approved these changes
Sep 11, 2022
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 13, 2022
* development: Create super-linter.yml (FreeTubeApp#2562) Update css-loader and switch to webpack 5's asset modules (FreeTubeApp#2566) Translated using Weblate (Spanish) Translated using Weblate (Portuguese (Brazil)) Remove unused ft-intersection-observer component (FreeTubeApp#2563) Remove unneeded electron-builder-squirrel-windows dependency (FreeTubeApp#2560) Update auto-label-issue GH workflow config to use multiline (FreeTubeApp#2565) Update sass and sass-loader to the latest versions (FreeTubeApp#2568) Translated using Weblate (Romanian) Translated using Weblate (Spanish) Translated using Weblate (Spanish) Translated using Weblate (Spanish) Translated using Weblate (Bulgarian) Use some rich format to improve README.md readability (FreeTubeApp#2456) # Conflicts: # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unneeded electron-builder-squirrel-windows dependency
Pull Request Type
Related issue
Related to #2113
Description
Squirrel builds were removed in #2113, this pull request removes the now unneeded
electron-builder-squirrel-windowsdependency.Testing (for code that is not small enough to be easily understandable)
I tested
yarn buildand nothing broke.Desktop (please complete the following information):