Fix small bug if imported xml has also the stardard namespace included#1832
Merged
oroulet merged 3 commits intoFreeOpcUa:masterfrom Apr 28, 2025
Merged
Fix small bug if imported xml has also the stardard namespace included#1832oroulet merged 3 commits intoFreeOpcUa:masterfrom
oroulet merged 3 commits intoFreeOpcUa:masterfrom
Conversation
Member
|
small linting issue |
Contributor
Author
|
@oroulet could you guide me? idk why the linter is failing. Is there a linter, which i can install locally to prevent these base checks from triggering? |
Member
|
This is the formater. Try 'ruff format ' |
Member
|
Maybe some documentation is missing... |
Contributor
Author
|
@oroulet reformated with ruff, hopefully everything is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This minor adjustment resolves a bug that occurs when importing an XML file with the standard "http://opcfoundation.org/UA/" namespace. Without this fix, the subsequent code would incorrectly shift all namespaces one level deeper, resulting in the following changes:
Level 1 namespaces being treated as Level 0
Level 2 namespaces being treated as Level 1 and so on.