Added preventOpenDuplicates global option. #89
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option prevents toasts that are currently open from having duplicates. Also fixed typo in documentation: extendedTimeOut.
Owner
|
Thanks, I will take a look soon. |
Owner
|
I merged it, it was a lovely patch. |
Contributor
Author
|
Great! Thank you. |
Owner
|
Re-checking it, I opened #96 . Is there any reason you created yet another way to track opened toasts? There is a toasts array already. I will clean up that. |
Contributor
Author
|
That was intended. The toasts array preserve the order and the object is just an efficient way to check if the toast exists. It could be replaced, but I really don't like the idea of looping an array every time. Of course that for most use cases, the normal amount of open toasts is very small. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option prevents toasts that are currently open from having duplicates.
Also fixed typo in documentation: extendedTimeOut.
The current
preventDuplicatesoption does not suit my needs. For example, if I displayed a toast after a request error and it timed out, I want the toast to be displayed again if it reoccurs.