[make] Recompile library when source files change #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build has been split up into separate object files, and each object file is recompiled if the relevant source/header file changes. Previously, it would never recompile the library, regardless of whether any files had changed, so running `make clean` was necessary every time.
Firstly, simdjson.cpp doesn't actually include simdjson.h, and luasimdjson.cpp includes both luasimdjson.h and simdjson.h. Rather than specifying the dependencies manually (where there is room for error) it's better to let the compiler describe the file dependencies (by generating .d files with -MMD and -MP), this avoids mistakes and doesn't require manual intervention if the files ever change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build has been split up into separate object files, and each object file is recompiled if the relevant source/header file changes.
Previously, it would never recompile the library, regardless of whether any files had changed, so running
make cleanwas necessary every time (which was inconvenient when I was doing a git bisect for #90).