[make] Add windows support #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobil4sk
force-pushed
the
feature/windows-support
branch
from
f317795 to
ea8d54e
Compare
On windows, we need to explicitly link against lua.dll
Since lua was built with VS2022, the luarocks install script uses `MSVCR80` as the default runtime which causes problems when loading dlls.
Contributor
Author
|
There was an issue running ci on windows-2022 (see luarocks/luarocks#1697), so I had to add a workaround 1958042.
|
tobil4sk
commented
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows, we need to generate a
.dllinstead of a.sofile, and we need to link explicitly against the lua library.Some of the changes here are adapted from: sebthom@2eec510