fix: move TurboModuleRegistry.getEnforcing to only happen on android
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was not sure about the fix label maybe its a feature:
According to React Native Documentation Modules are singletons:
After confirming that, I propose we make the small change of moving the
TurboModuleRegistry.getEnforcing<Spec>('DynamicTheme');call from being the default export of NativeDynamicTheme.ts to instead being called on-demand after the already existing platform checks (e.g. inside the if).Point being now the library can peacefully run in every other react native platform, Windows, Web, Vision OS, etc.
My change now makes (as I understand it) the ios code dead code, but I wanted to keep the PR focused.
Thanks.