Set type: module in package.json#18720
Closed
dbaynard wants to merge 1 commit into
Closed
Conversation
Node documentation recommends package authors explicitly set `"type": "module"`. Without this, sveltekit (and possibly other tooling) incorrectly treats the ES modules as CommonJS.
7 tasks
Author
|
Feel free to close, in favour of #19041 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18514
I’ve tested (for
free-solig-svg-icons) with sveltekit, building with the static adaptor — this change fixes the compile time error, in node.I’ve also tested with the auto adapter — this fixes the runtime (node) error.
Sadly my understanding of the javascript ecosystem is limited; I don’t know what consequences this change might have. According to Modules: Packages | Node.js v17.5.0 Documentation, though, the additional field is recommended.