Skip to content

Conversation

@nstolpe
Copy link
Contributor

@nstolpe nstolpe commented Oct 28, 2024

Description

Adds a check for a boolean value in label text and does not return a label component if that is the case.

Fixes #2923

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: a6d4d7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
victory-candlestick Patch
victory Patch
rn-demo Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-canvas Patch
victory-chart Patch
victory-core Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch
victory-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
victory ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 7:39pm

@nstolpe nstolpe linked an issue Oct 28, 2024 that may be closed by this pull request
@nstolpe nstolpe merged commit 1d6f7a8 into main Oct 28, 2024
9 checks passed
@nstolpe nstolpe deleted the fix/candlestick-midpoint-label branch October 28, 2024 20:55
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Candlestick labels show incorrect midpoint label

3 participants