Skip to content

Conversation

@nlkluth
Copy link
Contributor

@nlkluth nlkluth commented Oct 15, 2024

Description

Allows passing categories as string[]

Fixes #2903

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: cfe5686

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
victory-core Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-chart Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch
victory Patch
rn-demo Patch
victory-native Patch
victory-vendor Patch
victory-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
victory ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 4:39pm

carbonrobot
carbonrobot previously approved these changes Oct 16, 2024
@carbonrobot carbonrobot self-requested a review October 16, 2024 14:50
@nlkluth nlkluth merged commit 738b983 into main Oct 16, 2024
9 checks passed
@nlkluth nlkluth deleted the victory-bar-categories-array branch October 16, 2024 17:26
This was referenced Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VictoryBar does not supports passing the categories as a simple array (the documentation + types says that it should works)

3 participants