Feat: apply clean theme to foundational chart demos #2909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
September 25, 2024 11:44
🦋 Changeset detectedLatest commit: dbd21d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
carbonrobot
reviewed
Oct 8, 2024
carbonrobot
reviewed
Oct 8, 2024
ramenhog
force-pushed
the
feat/clean-theme-demos
branch
from
bd6fc8a to
3b04136
Compare
added 2 commits
October 8, 2024 15:10
carbonrobot
reviewed
Oct 9, 2024
Contributor
carbonrobot
left a comment
carbonrobot
left a comment
There was a problem hiding this comment.
Looks excellent! Can you run pnpm changeset locally and create a patch for "Minor updates for clean theme"
carbonrobot
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the following victory demos (of foundational Victory charts) to use the new clean theme:
**Upcoming todo: ** apply clean theme to remaining demos for more advanced Victory charting features.
Type of Change
How Has This Been Tested?
These demos have been manually checked on Chrome and Safari on MacOS.