fix: wrap preview in boundary #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 4761252 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Working on some minor changes here, will update shortly |
carbonrobot
force-pushed
the
fix-runtime-crash
branch
from
fe01f40 to
02e6b21
Compare
Contributor
|
Causes a regression on #393 |
carbonrobot
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
React-Live did not catch a runtime error (not caught in the transpile phase).
We can't catch all errors (like event handlers) but we can catch
useEffect's cleanup functions.Fixes #388
2024-08-15.18-14-26.mp4
The above video demonstrates, not a cleanup function not causing crash.
Worth noting, cleanup function runs one cycle "behind", therefore even if we correct the code the previous code with error still shows up.