Skip to content

Fix cursor position on new line, add demo app #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carloskelly13 merged 4 commits into from
May 13, 2023
Merged

Fix cursor position on new line, add demo app #358

carloskelly13 merged 4 commits into from
May 13, 2023

Conversation

@carloskelly13
Copy link
Contributor

@carloskelly13 carloskelly13 commented May 13, 2023 •
edited
Loading

  • Adds Vite-based demo app to test dev on this project
  • Fixes the cursor position on a new line by ensuring all elements in the editor tree are span, div causes the cursor to bounce, css ensures each line-token is rendered on its own line. as seen in Caret position not working as expected #343

To test:

Run the dev:demo task after building the library and recreate the above. The cursor should follow the new line.

@FormidableLabs FormidableLabs deleted a comment from vercel bot May 13, 2023
@vercel
Copy link

vercel bot commented May 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-live-docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2023 9:38pm

@carloskelly13 carloskelly13 requested a review from gksander May 13, 2023 21:39
gksander
gksander approved these changes May 13, 2023
View reviewed changes
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neato bandito

@carloskelly13 carloskelly13 merged commit 6284385 into master May 13, 2023
@carloskelly13 carloskelly13 deleted the task/fix-new-line-add-demo branch May 13, 2023 23:03
@github-actions github-actions bot mentioned this pull request May 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gksander gksander gksander approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carloskelly13 @gksander