Migrate codebase to pnpm + integrate prism react renderer 2 #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gksander
reviewed
May 8, 2023
Contributor
gksander
left a comment
gksander
left a comment
There was a problem hiding this comment.
Looks good, a few comments overall.
| "react": "^17.0.2", | ||
| "react-dom": "^17.0.2", | ||
| "react-live": "^4.0.0", | ||
| "prism-react-renderer": "*", |
Contributor
There was a problem hiding this comment.
should this be an explicit version, since PRR isn't part of this workspace?
Contributor
Author
There was a problem hiding this comment.
It isn't, but the * also means, I believe, use the version specified in the root package.json too.
Co-authored-by: Grant Sander <[email protected]>
gksander
approved these changes
May 10, 2023
Contributor
gksander
left a comment
gksander
left a comment
There was a problem hiding this comment.
My bad, this fell off my radar.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsupfor building the libraryAlso gets doc site previews → https://react-live-docs-website-git-task-pnpm-formidable-labs.vercel.app/