Skip to content

Improve the limitations page #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcabbott merged 2 commits into from
Jan 4, 2025
Merged

Improve the limitations page #1548

mcabbott merged 2 commits into from
Jan 4, 2025

Conversation

@mcabbott
Copy link
Member

@mcabbott mcabbott commented Jan 4, 2025 •
edited
Loading

This is far from perfect, but aims to:

  • discourage anyone from using Buffer, as it doesn't really work well, and
  • say more what it means to just avoid mutation. Maybe that could be longer still.

@mcabbott mcabbott mentioned this pull request Jan 4, 2025
Open
ToucheSir
ToucheSir approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The perfect is the enemy of the good, and given how much TLC the docs need this LGTM.

@mcabbott mcabbott merged commit 4fe2c9d into master Jan 4, 2025
10 of 13 checks passed
@mcabbott mcabbott deleted the mcabbott-patch-1 branch January 4, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ToucheSir ToucheSir ToucheSir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mcabbott @ToucheSir