remove show method for TrackedArray type#156
Merged
ChrisRackauckas merged 2 commits intoFluxML:masterfrom Nov 17, 2023
Merged
Conversation
This method causes horrible invalidations and causes havoc in loading times and compilation time after Tracker.jl is loaded. For example, loading Enzyme.jl goes from 0.5 seconds to 22 seconds if Tracker.jl is loaded first. The printing of types should hopefully have been improved enough in JuliaLang/julia#49795 that this is not needed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 72.53% 72.74% +0.20%
==========================================
Files 9 9
Lines 710 708 -2
==========================================
Hits 515 515
+ Misses 195 193 -2 ☔ View full report in Codecov by Sentry. |
ChrisRackauckas
approved these changes
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method causes horrible invalidations and causes havoc in loading times and compilation time after Tracker.jl is loaded.
For example, loading Enzyme.jl goes from 0.5 seconds to 22 seconds if Tracker.jl is loaded first.
The printing of types should hopefully have been improved enough in JuliaLang/julia#49795 that this is not needed.