Added values list to generated classes #270
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsly-ru
changed the title
|
Like it! Would be great for caching icons. @wasabeef |
|
I was about to implement the same feature, because I need this for 2 of my projects! Great work. |
Member
|
Thank you for your PR, I released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR implements a feature requested in #186.
It adds
valuesgetter at the end of generated classes for directories with the list of all statement' names.Possible problem:
Name collision of
valueswith an existing asset. Feel free to suggest some less generic name so I'll rename it (or simply edit it yourself). I just don't have any ideas about naming conventions for a predetermined field for this project.Possible improvement:
Make this list optional with some flag.