Data Entry MSB won't work if setting Data Entry LSB Value

[LoveBodhi]

Example:

NRPN MSB 120
NRPN LSB 4
Data Entry LSB 64
Data Entry MSB 64

It should receive LSB 64 MSB 64; but MSB won't work.

Version is between 2.4.0 and 2.4.3. I can't test on 2.4.4 because the important lib, SDL3, is missing.

[derselbst]

Thanks for the report!

@spessasus It looks like your change #1358 introduced a small regression. I created #1539 to add back the break statement when it receives the DATA_LSB event, at least for SF2 NRPNs. I'll have to double-check the order of DATA_ENTRY events in the AWE32 MIDIs and docs. And I'll once again need to look up the MIDI spec about their RPN.

[spessasus]

Thanks for the report!

@spessasus It looks like your change #1358 introduced a small regression. I created #1539 to add back the break statement when it receives the DATA_LSB event, at least for SF2 NRPNs. I'll have to double-check the order of DATA_ENTRY events in the AWE32 MIDIs and docs. And I'll once again need to look up the MIDI spec about their RPN.

Ah, sorry for the regression! It seems that I didn't test my PR too closely :(

[derselbst]

No problem.

The SF2 spec says that

The Continuous Controller Messages that make up a NRPN message (in order) are as follows:
NRPN SELECT MSB
NRPN SELECT LSB
DATA ENTRY LSB
DATA ENTRY MSB

---

AWE32 NRPN docs state:

In general, to send a NRPN message, the following steps are required :

1. send NRPN MSB with MSB of sound parameter
2. send NRPN LSB with LSB of sound parameter
3. send Data Entry MSB with MSB of sound parameter value
4. send Data Entry LSB with LSB of sound parameter value

By coincidence we found that Data Entry MSB can be completely omitted for some AWE32 NRPNs, which only have a valid value range of [0;127].

---

Complete MIDI spec 1.0 - "Use of Data Entry Controllers" is pretty vague:

Composers adjusting RPNs should utilize the Data Entry MSB (CC# 6) and, if necessary, the Data Entry LSB (CC #38),

---

Not very definite, but it looks like my proposal is correct.