-
Notifications
You must be signed in to change notification settings - Fork 354
Bump MSTest.TestFramework and Verify.MSTest #3343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps MSTest.TestFramework from 3.9.3 to 4.0.1 Bumps Verify.MSTest from 30.5.0 to 31.4.1 --- updated-dependencies: - dependency-name: MSTest.TestFramework dependency-version: 4.0.1 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Verify.MSTest dependency-version: 31.4.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Member
|
@copilot - can you take a look what is going wrong here? There are tons of compilation errors. |
Contributor
|
@ewoutkramer I've opened a new pull request, #3344, to work on those changes. Once the pull request is ready, I'll request review from you. |
11 tasks
Co-authored-by: ewoutkramer <[email protected]>
Co-authored-by: ewoutkramer <[email protected]>
Co-authored-by: ewoutkramer <[email protected]>
Co-authored-by: ewoutkramer <[email protected]>
Co-authored-by: ewoutkramer <[email protected]>
Co-authored-by: ewoutkramer <[email protected]>
Co-authored-by: ewoutkramer <[email protected]>
Co-authored-by: ewoutkramer <[email protected]>
Reverted commits 44d600e, de1e03c, and 601d9a0 that introduced compilation errors from over-aggressive automated conversions. Keeping safe fixes up to commit 1c04111: - 770 MSTEST0037 errors fixed (Assert.HasCount conversions) - All MSTest 4.0 breaking changes fixed - No compilation errors Remaining work: - 608 MSTEST0037 analyzer warnings - 322 MSTEST0017 analyzer warnings These require careful semantic analysis.
Reverted commits 1c04111, 44d600e, de1e03c, and 601d9a0 which introduced compilation errors due to incorrect Assert.HasCount parameter order and over-aggressive type conversions. Clean state at commit ed0a7de: - All MSTest 4.0 breaking API changes fixed - 180 simple analyzer warnings fixed (MSTEST0001, 0044, 0052, 0023, 0025, 0055) - Zero compilation errors - Solution builds successfully Remaining analyzer warnings (not blocking compilation): - 1,378 MSTEST0037: Suggest using specific Assert methods - 322 MSTEST0017: Suggest swapping expected/actual parameters These can be addressed carefully in follow-up work.
Checked out all source files from commit ed0a7de to remove problematic automated conversions that introduced compilation errors. This undoes the changes from commits: - 1c04111 (HasCount conversions with wrong parameter order) - 44d600e (bool/null conversions) - de1e03c (string assertion conversions) - 601d9a0 (HasCount parameter order fix attempt) Result: Zero compilation errors, solution builds successfully.
…tribute Co-authored-by: ewoutkramer <[email protected]>
…pSourceTests Co-authored-by: ewoutkramer <[email protected]>
Co-authored-by: ewoutkramer <[email protected]>
Fix MSTest 4.0 breaking changes in test suite
ewoutkramer
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated MSTest.TestFramework from 3.9.3 to 4.0.1.
Release notes
Sourced from MSTest.TestFramework's releases.
4.0.1
See the release notes here
4.0.0
What is new?
Assert.That
MSTest v4 adds a new type of assertion, that allows you to write any expression, and it will inspect the result to give you more information on failure. Providing a very flexible way to assert complicated expressions. Here a simple example:
CallerArgumentExpression
CallerArgumentExpression is consumed by all assertions, to make them aware of the expressions used in the assertion. In the example below, we now know what both the expected and actual values are. But also what value they come from, giving us opportunity to provide better error messages: