Skip to content

Conversation

@JoostK
Copy link
Contributor

@JoostK JoostK commented Nov 18, 2025

… argument for null return values

Fixes #5401

… to input argument for `null` return values

Fixes FasterXML#5401
@JoostK JoostK force-pushed the json-creator-null-fix branch from d85e4b1 to 834c3e4 Compare November 18, 2025 10:44
@cowtowncoder
Copy link
Member

Makes sense, but I am puzzled by original code -- why is it returning argument instead of null... :-/

@stevenschlansker Any idea on ^^^?

@stevenschlansker
Copy link
Contributor

Sorry, I'm not sure. Seems good to remove to me.

@cowtowncoder
Copy link
Member

@stevenschlansker All good -- did not mean as in "WTH" but more like "is this safe to remove" :)
So sanity check so we won't remove something important.

@cowtowncoder cowtowncoder added the cla-needed PR looks good (although may also require code review), but CLA needed from submitter label Nov 19, 2025
@cowtowncoder
Copy link
Member

So, looks good, thank you @JoostK !

Just one thing before I merge (and back-port in 3.0(.3)) -- unless we have one already, need CLA from here:

https://github.com/FasterXML/jackson/blob/main/contributor-agreement.pdf

Only needs to be sent once, good for all future contributions.
The usual way is to print, fill & sign, scan/photo, email to cla at fasterxml dot com.

Once we have it, I can merge this in. Thanks again!

@JoostK
Copy link
Contributor Author

JoostK commented Nov 19, 2025

Only needs to be sent once, good for all future contributions. The usual way is to print, fill & sign, scan/photo, email to cla at fasterxml dot com.

Done

@cowtowncoder cowtowncoder added cla-received PR already covered by CLA (optional label) 3.0 Issue planned for initial 3.0 release and removed cla-needed PR looks good (although may also require code review), but CLA needed from submitter labels Nov 20, 2025
@cowtowncoder cowtowncoder merged commit 21cb537 into FasterXML:3.x Nov 20, 2025
6 checks passed
@cowtowncoder cowtowncoder added this to the 3.0.3 milestone Nov 20, 2025
@cowtowncoder
Copy link
Member

Merged in, backported in 3.0 for 3.0.3 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0 Issue planned for initial 3.0 release cla-received PR already covered by CLA (optional label)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression with @JsonCreator that returns null for empty strings

3 participants