-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix #5401 Single-arg method invocations should not fall back to input… #5402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… to input argument for `null` return values Fixes FasterXML#5401
d85e4b1 to
834c3e4
Compare
src/test/java/tools/jackson/databind/deser/creators/JsonCreatorReturningNull4938Test.java
Outdated
Show resolved
Hide resolved
|
Makes sense, but I am puzzled by original code -- why is it returning argument instead of null... :-/ @stevenschlansker Any idea on ^^^? |
|
Sorry, I'm not sure. Seems good to remove to me. |
|
@stevenschlansker All good -- did not mean as in "WTH" but more like "is this safe to remove" :) |
|
So, looks good, thank you @JoostK ! Just one thing before I merge (and back-port in 3.0(.3)) -- unless we have one already, need CLA from here: https://github.com/FasterXML/jackson/blob/main/contributor-agreement.pdf Only needs to be sent once, good for all future contributions. Once we have it, I can merge this in. Thanks again! |
Done |
|
Merged in, backported in |
… argument for
nullreturn valuesFixes #5401