Skip to content

[SM64] Fix object rotations#339

Merged
Dragorn421 merged 1 commit intoFast-64:mainfrom
Lilaa3:fix_sm64_object_rotations
May 20, 2024
Merged

[SM64] Fix object rotations#339
Dragorn421 merged 1 commit intoFast-64:mainfrom
Lilaa3:fix_sm64_object_rotations

Conversation

@Lilaa3
Copy link
Collaborator

@Lilaa3 Lilaa3 commented Apr 22, 2024

Export code was not accounting for the zxy order of object rotations (animations rotate xyz so they don't have this issue), this pr fixes that (see #320)

Copy link
Collaborator

@jesusyoshi54 jesusyoshi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@jesusyoshi54 jesusyoshi54 added the merge soon Will be merged in a few days at most if nothing else comes up label May 11, 2024
@Dragorn421 Dragorn421 merged commit eee1c34 into Fast-64:main May 20, 2024
Lilaa3 added a commit to Lilaa3/fast64 that referenced this pull request Aug 22, 2024
The previous fix was incomplete but the issue was never noticed from how uncommon camera volumes are.
Previous fix was a fix to Fast-64#339
Lilaa3 added a commit to Lilaa3/fast64 that referenced this pull request Aug 22, 2024
The previous fix was incomplete but the issue was never noticed from how uncommon camera volumes are.
Previous fix was a fix to Fast-64#339
Lilaa3 added a commit that referenced this pull request Aug 23, 2024
The previous fix was incomplete but the issue was never noticed from how uncommon camera volumes are.
Previous fix was a fix to #339
@Lilaa3 Lilaa3 deleted the fix_sm64_object_rotations branch August 24, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge soon Will be merged in a few days at most if nothing else comes up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants