[bugfix] SM64 mat override fixes#207
Merged
kurethedead merged 8 commits intoFast-64:mainfrom Jan 10, 2023
Merged
Conversation
added 7 commits
November 28, 2022 18:45
Dragorn421
reviewed
Dec 23, 2022
kurethedead
approved these changes
Jan 10, 2023
Contributor
kurethedead
left a comment
kurethedead
left a comment
There was a problem hiding this comment.
I played played SM64 from new game to 8 stars to confirm that it seems to work correctly.
kurethedead
added
the
merge soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with material overrides where excessive reverts were added to display lists with the recent changes to gbiMacro hashing behavior.
This change opts to instead not use sets, and manage the commands in command lists by adding and removing commands via id.