Add registration functions for envs and intelligence backends#115
Merged
elliottower merged 3 commits intoFarama-Foundation:mainfrom Dec 19, 2023
Merged
Conversation
elliottower
approved these changes
Dec 15, 2023
Contributor
elliottower
left a comment
elliottower
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the contribution. Definitely a cleaner way to do things.
Contributor
|
Is there any chance you could update the tests to run this registration process for all of the built in environments? I see the test_environments file has been updated but as far as I can tell it only does it for the chess environment. They are tested in the arena tests as well but probably good to have a more specific test about this registration component for each env. |
Contributor
Author
|
Sweet! Thanks for developing and maintaining this--I hope to make additional helpful contributions as I use it. I've added tests for loading each of the builtin environments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds registration functions so that people can use
Arena.from_configwith custom environments and intelligence backends without needing to modify the ENVIRONMENT_REGISTRY or BACKEND_REGISTRY dicts.