Bug Fix for the RGBImgPartialObsWrapper view size issue#421
Open
vishwassathish wants to merge 4 commits into
Open
Bug Fix for the RGBImgPartialObsWrapper view size issue#421vishwassathish wants to merge 4 commits into
vishwassathish wants to merge 4 commits into
Conversation
Added comments for every bug fix change
1 task
pseudo-rnd-thoughts
requested changes
Feb 26, 2024
pseudo-rnd-thoughts
left a comment
Member
There was a problem hiding this comment.
Could you add a test for this
Member
|
@vishwassathish could you please fix the merge conflicts, pull in main and make sure CI passes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As reported in the bug, the
RGBImgPartialObsWrapperignored changes toagent_view_sizeparameter when rendering an RGB image. The issue was replicated and it was found thatenv.agent_view_sizeandenv.unwrapped.agent_view_sizehad different values after applying a view size wrapperViewSizeWrapper(env, agent_view_size=5).Fixes # (issue)
Made a small change to the
RGBImgPartialObsWrappermethod inwrappers.pyby adding anagent_view_sizeparameter. Also passed this argument toget_pov_render()andgen_obs_grid()functions inminigrid_env.pyType of change
Please delete options that are not relevant.
Screenshots
Please attach before and after screenshots of the change if applicable.


Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)