Skip to content

[Issue] - Fix HudElementRegistry.replaceElement() for subtitles during gameplay. #5012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
modmuss50 merged 9 commits into from
Jan 5, 2026
+51 −5
Merged

[Issue] - Fix HudElementRegistry.replaceElement() for subtitles during gameplay. #5012

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
db55ab2
[Issue] - Enhance subtitle overlay rendering in GuiMixin.
Liam-Broome Nov 19, 2025
029221f
Fix indentation in GuiMixin subtitle rendering
Liam-Broome Nov 19, 2025
6e4935b
Merge branch '1.21.11' into issue/4933
modmuss50 Nov 21, 2025
d28ab22
Refactor subtitle overlay rendering to new mixin
Liam-Broome Nov 22, 2025
a44b07c
Clean up formatting in SubtitleOverlayMixin
Liam-Broome Nov 22, 2025
b276b6d
Cleanup SubtitleOverlayMixin
ekulxam Dec 8, 2025
a2097d0
Fix checkstyle
ekulxam Dec 8, 2025
2aa4375
Merge pull request #1 from ekulxam/issue/4933
Liam-Broome Dec 8, 2025
3e7556c
Merge branch '1.21.11' into issue/4933
Liam-Broome Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions fabric-rendering-v1/src/client/java/net/fabricmc/fabric/mixin/client/rendering/GuiMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ abstract class GuiMixin {
@Final
private Minecraft minecraft;

@Shadow
private Runnable deferredSubtitles;

@Inject(method = "render", at = @At(value = "TAIL"))
public void render(GuiGraphics drawContext, DeltaTracker tickCounter, CallbackInfo callbackInfo) {
HudRenderCallback.EVENT.invoker().onHudRender(drawContext, tickCounter);
Expand Down Expand Up @@ -161,7 +164,19 @@ private void wrapPlayerList(Gui instance, GuiGraphics context, DeltaTracker tick
}

@WrapOperation(method = "render", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/gui/Gui;renderSubtitleOverlay(Lnet/minecraft/client/gui/GuiGraphics;Z)V"))
Copy link
Contributor

@ekulxam ekulxam Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with this mixin, see https://discord.com/channels/507304429255393322/807617700734042122/1440940666829013103.

I think it would better to instead mixin into the renderSubtitleOverlay method (and the lambda) to wrap the subtitleOverlay#render (as shown in the image).
As stated by @cassiancc, we can obtain the DeltaTracker/RenderTickCounter from the client so my suggested change may actually be better.

Copy link
Contributor Author

@Liam-Broome Liam-Broome Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekulxam - I have made some changes, thanks for the feedback 😄

private void wrapSubtitlesHud(Gui instance, GuiGraphics context, boolean bl, Operation<Void> renderVanilla, @Local(argsOnly = true) DeltaTracker tickCounter) {
HudElementRegistryImpl.getRoot(VanillaHudElements.SUBTITLES).render(context, tickCounter, (ctx, tc) -> renderVanilla.call(instance, ctx, bl));
private void wrapSubtitlesHud(Gui instance, GuiGraphics context, boolean deferRendering, Operation<Void> renderVanilla, @Local(argsOnly = true) DeltaTracker tickCounter) {
if (deferRendering) {
Runnable originalDeferred = this.deferredSubtitles;
renderVanilla.call(instance, context, true);
Runnable newDeferred = this.deferredSubtitles;

if (newDeferred != null && newDeferred != originalDeferred) {
this.deferredSubtitles = () -> HudElementRegistryImpl.getRoot(VanillaHudElements.SUBTITLES)
.render(context, tickCounter, (ctx, tc) -> newDeferred.run());
}
} else {
HudElementRegistryImpl.getRoot(VanillaHudElements.SUBTITLES)
.render(context, tickCounter, (ctx, tc) -> renderVanilla.call(instance, ctx, false));
}
}
}
Loading