Zebra: Enhancements for rtm_table field in FPM netlink message#4365
Zebra: Enhancements for rtm_table field in FPM netlink message#4365donaldsharp merged 1 commit intoFRRouting:masterfrom
Conversation
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7742/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
12 Static Analyzer issues remaining.See details at |
- Today, rtm_table field takes a vrf_id. It should take table_id - rtm_table field is a uchar field which can only accomodate table_id less than 256. To support table id greater than 255, if the table_id is greater than 255, set rtm_table to 0 and add RTA_TABLE attribute with 32 bit value as the table_id. Signed-off-by: Ameya Dharkar <[email protected]>
6817b09 to
6dfcd75
Compare
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7744/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
12 Static Analyzer issues remaining.See details at |
|
LGTM. @eqvinox has expressed a desire to look at this one as well. I am going to give him a day or so to look at it as well. |
|
btw -> Once this goes in, I am going to send an email announcement to the dev alias to further document this issue so that people who encounter it later will have a starting place for our line of thought and what needs to be done. |
256. To support table id greater than 255, if the table_id is greater than 255,
set rtm_table to 0 and add RTA_TABLE attribute with 32 bit value as the
table_id.
Signed-off-by: Ameya Dharkar [email protected]