Skip to content

ospfd: fix sequence number check, avoid truncation ambiguity (backport #21096)#21111

Merged
Jafaral merged 2 commits intostable/10.5from
mergify/bp/stable/10.5/pr-21096
Mar 12, 2026
Merged

ospfd: fix sequence number check, avoid truncation ambiguity (backport #21096)#21111
Jafaral merged 2 commits intostable/10.5from
mergify/bp/stable/10.5/pr-21096

Conversation

@mergify
Copy link

@mergify mergify bot commented Mar 12, 2026

ospfd: reject equal cryptographic sequence numbers
Require strictly increasing OSPF crypt sequence numbers for MD5 and HMAC-SHA
authentication checks to prevent replay of the last accepted packet.


ospfd: use 32-bit LS Update LSA count
Match ospf_ls_upd_list_lsa() count type to the 32-bit on-wire field
to avoid truncation ambiguity and keep parsing semantics consistent
with packet validation.<hr>This is an automatic backport of pull request #21096 done by [Mergify](https://mergify.com).

Jafaral added 2 commits March 12, 2026 12:00
Match ospf_ls_upd_list_lsa() count type to the 32-bit on-wire field
to avoid truncation ambiguity and keep parsing semantics consistent
with packet validation.

Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
(cherry picked from commit 9d9053a)
Require strictly increasing OSPF crypt sequence numbers for MD5 and HMAC-SHA
authentication checks to prevent replay of the last accepted packet.

Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
(cherry picked from commit 330442f)
@greptile-apps
Copy link

greptile-apps bot commented Mar 12, 2026

Target branch is not in the allowed branches list.

@frrbot frrbot bot added the ospf label Mar 12, 2026
@Jafaral Jafaral merged commit dceb42c into stable/10.5 Mar 12, 2026
20 checks passed
@mergify mergify bot deleted the mergify/bp/stable/10.5/pr-21096 branch March 12, 2026 14:57
@mattiaswal mattiaswal mentioned this pull request Mar 18, 2026
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant