tests: Fix bgp_srv6_sid_explicit test failures #19068
Merged
Jafaral merged 1 commit intoFRRouting:masterfrom Jun 23, 2025
Merged
tests: Fix bgp_srv6_sid_explicit test failures #19068Jafaral merged 1 commit intoFRRouting:masterfrom
bgp_srv6_sid_explicit test failures #19068Jafaral merged 1 commit intoFRRouting:masterfrom
Conversation
Contributor
Author
|
@Mergifyio backport dev/10.4 |
✅ Backports have been createdDetails
|
Contributor
Author
|
ci:rerun |
ahsalam
approved these changes
Jun 22, 2025
Jafaral
requested changes
Jun 22, 2025
Member
There was a problem hiding this comment.
I know we generally ask to split large commits of unrelated changes. But In this case, the numbers of commits is so excessive and unnecessary. Turning IPv6 off doesn't really need 6 commits. It is the same change. In fact, all fixes are simple , related, and repeated from one file to the next. Just squash them all to one and call it good.
Add a summary of the changes you made to the description of the one commit. Some points to keep in mind:
- No need to mention file names unless it add value the description, In the vast majority of cases you don't need it. And if you think you want to explain something in depth about a change to a file, then you probably have make that a commit and explain that change, and you still don't need to refer to the file name. Saying something like "drop 'ip forward' from r2/frr.conf" doesn't really add value. git already shows me what files have changes and what the changes are. Your description should be about "why", not how and where.
- Please avoid using the same commit message and description in two commits. If you think you need that, it is an indication that those two commits should be squashed.
The routers in the topology have IPv6 forwarding capability disabled. This causes the kernel to install an unexpected mngtmpaddr address (Privacy Extensions RFC3041), which may cause test failures. Routers should have the IPv6 forwarding capability enabled to work properly as routers. Also, clean up the router configuration files by removing unnecessary stuff. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
cscarpitta
force-pushed
the
fix/fix_bgp_srv6_sid_explicit_test_failure
branch
from
538612c to
d020d44
Compare
Contributor
Author
|
@Jafaral Squashed and updated the commit description. Thanks for the hints. |
Jafaral
approved these changes
Jun 23, 2025
Jafaral
added a commit
that referenced
this pull request
Jun 24, 2025
tests: Fix `bgp_srv6_sid_explicit` test failures (backport #19068)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routers in
bgp_srv6_sid_explicittopotest have IPv6 forwarding capability disabled. This causes the kernel to install an unexpected mngtmpaddr address (Privacy Extensions RFC3041), which may cause test failures.Routers should have the IPv6 forwarding capability enabled to work properly as routers.