pathd: fix compare function overflow

[guoguojia2021]

Test code:

int compare(uint32_t x, uint32_t y) {
    return x - y;
}

void print_compare(uint32_t x, uint32_t y) {
    int ret = compare(x, y);
    if (ret < 0) {
        printf("%u < %u\n", x, y);
    } else if (ret > 0) {
        printf("%u > %u\n", x, y);
    } else {
        printf("%u = %u\n", x, y);
    }
}

int main(void) {
    uint32_t a = 2;
    uint32_t b = 0x80000001u;
    uint32_t c = 0xffffffffu;
    print_compare(a, b);
    print_compare(b, c);
    print_compare(c, a);

    uint32_t x = 7;
    uint32_t y = 0x80000007u;
    print_compare(x, y);
    print_compare(y, x);
    return 0;
}

Output:

2 < 2147483649
2147483649 < 4294967295
4294967295 < 2

[ton31337]

LGTM

[Jafaral]

@Mergifyio backport dev/10.4

[mergify]

backport dev/10.4

✅ Backports have been created

Details

• #19053 pathd: fix compare function overflow (backport #19050) has been created for branch dev/10.4