Skip to content

zebra: Start EVPN neighbor hold timer only when interface is operative#18905

Merged
ton31337 merged 1 commit intoFRRouting:masterfrom
routingrocks:rvaratharaj/evpn_peer_sync
Jun 18, 2025
Merged

zebra: Start EVPN neighbor hold timer only when interface is operative#18905
ton31337 merged 1 commit intoFRRouting:masterfrom
routingrocks:rvaratharaj/evpn_peer_sync

Conversation

@routingrocks
Copy link
Contributor

@routingrocks routingrocks commented May 29, 2025

  • Fix issue where mh_peer_sync flag was missing on EVPN MH neighbor entries after networking service restart. Earlier the hold timer for the ES_PEER_ACTIVE flag was unconditionally started when a sync neighbor was deleted. which removes the sync flag.

  • Added more debugs

Ticket: #
Signed-off-by: Rajesh Varatharaj rvaratharaj@nvidia.com

@frrbot frrbot bot added the zebra label May 29, 2025
@routingrocks routingrocks marked this pull request as draft May 29, 2025 04:44
@routingrocks routingrocks force-pushed the rvaratharaj/evpn_peer_sync branch 2 times, most recently from 78c485f to 91a679d Compare May 29, 2025 19:14
@routingrocks routingrocks marked this pull request as ready for review May 29, 2025 19:40
@routingrocks routingrocks marked this pull request as draft May 30, 2025 03:17
@routingrocks routingrocks marked this pull request as ready for review June 2, 2025 19:50
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
Copy link
Member

riw777 commented Jun 3, 2025

failure is unrelated ... trying again ...

ci:rerun

@routingrocks routingrocks force-pushed the rvaratharaj/evpn_peer_sync branch from 91a679d to 4b8d708 Compare June 4, 2025 21:30
@github-actions github-actions bot added the rebase PR needs rebase label Jun 4, 2025
@routingrocks
Copy link
Contributor Author

ci:rerun

@routingrocks routingrocks force-pushed the rvaratharaj/evpn_peer_sync branch 4 times, most recently from fcf2db9 to c69ab98 Compare June 10, 2025 18:05
@routingrocks
Copy link
Contributor Author

ci:rerun

@routingrocks routingrocks force-pushed the rvaratharaj/evpn_peer_sync branch from c69ab98 to 439d6d0 Compare June 12, 2025 16:54
@routingrocks
Copy link
Contributor Author

ci:rerun

- Fix issue where mh_peer_sync flag was missing on EVPN MH neighbor entries
after networking service restart. Earlier the hold timer for the
ES_PEER_ACTIVE flag was unconditionally started when a sync neighbor was
deleted. which removes the sync flag.

- Added more debugs

Ticket: #
Signed-off-by: Rajesh Varatharaj <rvaratharaj@nvidia.com>
@routingrocks routingrocks force-pushed the rvaratharaj/evpn_peer_sync branch from 439d6d0 to 90c1c46 Compare June 13, 2025 02:16
@routingrocks
Copy link
Contributor Author

ci:rerun

1 similar comment
@routingrocks
Copy link
Contributor Author

ci:rerun

@routingrocks routingrocks requested a review from ton31337 June 17, 2025 23:20
@ton31337 ton31337 merged commit 8b6e01b into FRRouting:master Jun 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants